Extend accepted parameters #3583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's all the same in its essence. Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
added
compiler
roman-khimov
force-pushed
the
extend-accepted-parameters
branch
from
f134387
to
c912480
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3583 +/- ##
==========================================
+ Coverage 85.85% 85.86% +0.01%
==========================================
Files 330 330
Lines 38537 38567 +30
==========================================
+ Hits 33085 33116 +31
+ Misses 3904 3902 -2
- Partials 1548 1549 +1 ☔ View full report in Codecov by Sentry. |
It's _very_ annoying to not be able to use []string types properly:
test invocation failed: unsupported parameter []string
But the same thing can happen to any other slice, so accept slices of every
basic type we accept above. Reorder tests to match implementation switch as
well.
Signed-off-by: Roman Khimov <[email protected]>
roman-khimov
force-pushed
the
extend-accepted-parameters
branch
from
c912480
to
8469f97
Compare
AnnaShaleva
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Contracts with
methods(some []string)generate RPC bindings with[]stringparameters. But these bindings are unusable by default because we can't convert[]stringto parameters.Solution
Extend accepted type list.